The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
rivetkit-serverless	Error			Dec 11, 2025 8:35pm

3 Skipped Deployments

Project	Deployment	Preview	Comments	Updated (UTC)
rivet-cloud	Ignored			Dec 11, 2025 8:35pm
rivet-inspector	Ignored	Preview		Dec 11, 2025 8:35pm
rivet-site	Ignored	Preview		Dec 11, 2025 8:35pm

• chore: add websocket close logs #3633
• chore: clean up scripts #3630
• fix(guard): use moka cache for in flight reqs #3629
• fix: add debug logs for config loading #3628 👈 (View in Graphite)
• fix(backport): fix serverless #3622
• fix: add serverless backfill #3588 : 1 other dependent PR (#3617 )
• chore: fix runner config creation #3580
• main

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Pull Request Review

Summary

This PR adds debug logging to the config loading process in the engine/packages/config module. The changes help with debugging and troubleshooting configuration loading issues.

✅ Positive Aspects

1. Good logging practices: The structured logging follows the project's conventions correctly:

   • Uses tracing::debug! with structured parameters (path=%path.display())
   • Log messages are lowercase as per CLAUDE.md guidelines
   • Appropriate debug level for operational information

2. Dependency management: Correctly added tracing.workspace = true to use the workspace dependency

3. Improved error message: The enhanced error message at line 107-110 is more helpful, providing guidance on what the path should be

📝 Observations

1. Test coverage: This module appears to have no test coverage. While the changes themselves are low-risk, adding tests would help ensure config loading behavior remains correct, especially around:

   • Directory traversal
   • File type filtering
   • Error conditions

2. Log message consistency: The log messages are clear, but consider adding more context:

   • Line 82: Could mention why it's being ignored (e.g., "optional config path")
   • Lines 89, 103: Could include file count or file names being loaded for better observability

3. Minor suggestion: At line 82, the comment "Silently ignore non-existent paths" is now contradictory since we're logging. Consider updating to "Ignore optional non-existent paths" or removing the comment since the log message is self-documenting.

🔒 Security & Performance

• ✅ No security concerns identified
• ✅ Debug logging has minimal performance impact
• ✅ No sensitive information logged

🐛 Potential Issues

None identified. The changes are straightforward and low-risk.

Recommendations

1. Optional improvement: Consider adding file names to directory logging for better observability
2. Consider adding: A log at the start of Config::load() showing which paths will be attempted (for complete observability)
3. Future work: Add test coverage for this module

Verdict

✅ Approved - This is a solid improvement that will help with debugging config loading issues. The code follows project conventions and introduces no risks. The suggestions above are optional enhancements, not blockers.

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/cloudflare-workers@3628

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/db@3628

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/framework-base@3628

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/next-js@3628

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/react@3628

pnpm add https://pkg.pr.new/rivet-dev/rivet/rivetkit@3628

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sql-loader@3628

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner@3628

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner-protocol@3628

commit: d3c694a

Merge activity

• Dec 12, 12:48 AM UTC: NathanFlurry added this pull request to the Graphite merge queue.
• Dec 12, 12:49 AM UTC: CI is running for this pull request on a draft pull request (#3634) due to your merge queue CI optimization settings.
• Dec 12, 12:49 AM UTC: Merged by the Graphite merge queue via draft PR: #3634.